[PATCH] D72966: Remove AllTargetsAsmPrinters

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 16:18:00 PST 2020


thakis added a comment.

In D72966#1827771 <https://reviews.llvm.org/D72966#1827771>, @MaskRay wrote:

> Thanks for fixing CMake:)
>
> The empty target seems to have caused the failure in http://45.33.8.238/linux/7815/step_4.txt


What has happened there (I think) is that @epastor copied the llvm-ml cmakelists.txt from an existing cmakelists.txt that had the AllTargetsAsmPrinters target, and the copied that to the gn build file – and the gn build is a bit more explicit about which things exist and which don't :) (I had fixed the gn build in 6afa0e88e32558 <https://reviews.llvm.org/rG6afa0e88e32558c115e72797baf57b86cfa37e07>)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72966/new/

https://reviews.llvm.org/D72966





More information about the llvm-commits mailing list