[PATCH] D72885: [WIP] Add Query API for llvm.assume holding attributes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I won't review this properly till next week. Generally looks good so you can work on the next patch if you want to.



================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:239
+  ShouldPreserveAllAttributes.setValue(PreviousValue);
+}
----------------
Tyker wrote:
> jdoerfert wrote:
> > Where is this used?
> this is used for testing ShouldPreserveAllAttributes option from unittests.
If it's only used in the unit test can we move it there?


================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:251
+  return true;
+}
+
----------------
What is the use case for `IsOn = nullptr`? If there is none, we should make it a reference so it's obvious. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72885/new/

https://reviews.llvm.org/D72885