[PATCH] D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 17 15:20:58 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG128e1ebd9310: [CMake] Prefer multi-target variables over generic target variables in runtimes… (authored by JamesNagurne, committed by phosek).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71570/new/
https://reviews.llvm.org/D71570
Files:
llvm/runtimes/CMakeLists.txt
Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -448,14 +448,16 @@
get_cmake_property(variableNames VARIABLES)
foreach(variableName ${variableNames})
- string(FIND "${variableName}" "RUNTIMES_${name}_" out)
+ string(FIND "${variableName}" "RUNTIMES_${target}_" out)
if("${out}" EQUAL 0)
- string(REPLACE "RUNTIMES_${name}_" "" new_name ${variableName})
+ string(REPLACE "RUNTIMES_${target}_" "" new_name ${variableName})
list(APPEND ${name}_extra_args "-D${new_name}=${${variableName}}")
endif()
- string(FIND "${variableName}" "RUNTIMES_${target}_" out)
+ endforeach()
+ foreach(variableName ${variableNames})
+ string(FIND "${variableName}" "RUNTIMES_${name}_" out)
if("${out}" EQUAL 0)
- string(REPLACE "RUNTIMES_${target}_" "" new_name ${variableName})
+ string(REPLACE "RUNTIMES_${name}_" "" new_name ${variableName})
list(APPEND ${name}_extra_args "-D${new_name}=${${variableName}}")
endif()
endforeach()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71570.238905.patch
Type: text/x-patch
Size: 1153 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/9cfe4d7d/attachment.bin>
More information about the llvm-commits
mailing list