[PATCH] D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw

Fri Jan 17 11:30:28 PST 2020

mehdi_amini added a comment.

In D72741#1826956 <https://reviews.llvm.org/D72741#1826956>, @jfb wrote:

> In D72741#1826938 <https://reviews.llvm.org/D72741#1826938>, @flaub wrote:
>
> > @ftynse I believe this is ready to go, anything else you'd like?
> >
> > Also, I don't yet have committer access, so I'll need some help getting it landed.
>
>
> Please resolve the question I asked, either here or with a follow-up plan. @mehdi_amini's suggestion was good.

I wasn't intending to block this revision, I am aligned with @ftynse and @nicolasvasilache that the LLVM dialect in MLIR is intended to mirror as close as possible LLVM IR and so aligning the naming makes sense to me.

I am very supportive to take the opportunity of revisions like the current one to surface issues with LLVM and work towards fixing them, I don't think we need to block the progress on the work on completing the MLIR<->LLVM mapping though. 
I was following up on your question with this mindset.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72741/new/

https://reviews.llvm.org/D72741