[PATCH] D72933: BEGIN_PUBLIC Adds CastSliceOp to the vector ops dialect.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1651
+  int64_t resultSliceCount = 1;
+  for (unsigned i = 0; i < resultVectorType.getRank(); ++i)
+    resultSliceCount *= ceilDiv(resultVectorShape[i], resultSizes[i]);
----------------
Cache the end iterator here and above.


================
Comment at: mlir/test/Dialect/VectorOps/ops.mlir:248
+}
\ No newline at end of file

----------------
Seems to be missing a newline here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72933/new/

https://reviews.llvm.org/D72933