[PATCH] D72933: BEGIN_PUBLIC Adds CastSliceOp to the vector ops dialect.

[Aart Bik via Phabricator via llvm-commits]

aartbik requested changes to this revision.
aartbik added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:951
+  let description = [{
+    The cast_slices vector operation type casts slices from a 'source' vector
+    to slices of a 'result' vector, where there is a one-to-one mapping
----------------
I would like to see a bit more documentation of this operation in terms of ranks and sizes of the arrays, like we do for the other sliced operations (so, like "n-D" with restrictions on n array sizes for the input arguments and output).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72933/new/

https://reviews.llvm.org/D72933