[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

[David Tenty via Phabricator via llvm-commits]

daltenty marked an inline comment as done.
daltenty added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1806
+    return;
+
   if ((!GVKind.isCommon() && !GVKind.isBSS() && !GVKind.isData() &&
----------------
hubert.reinterpretcast wrote:
> Assert `!GV->isDeclaration()` here to be sure that `GVKind` has been initialized.
The branch on `!GV->hasInitializer()` above guarantees this, `GV->hasInitializer()` is defined as `!isDeclaration()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347