[PATCH] D72924: [mlir][spirv] Add `const` qualifier for static arrays

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 08:46:58 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG8bcf976841f5: [mlir][spirv] Add `const` qualifier for static arrays (authored by antiagainst).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72924/new/

https://reviews.llvm.org/D72924

Files:
  mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
  mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp


Index: mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp
===================================================================
--- mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp
+++ mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp
@@ -1305,7 +1305,7 @@
       continue;
 
     os << "  case Capability::" << enumerant.getSymbol()
-       << ": {static Capability implies[] = {";
+       << ": {static const Capability implies[] = {";
     std::vector<Record *> impliedCapsDefs = def.getValueAsListOfDefs("implies");
     mlir::interleaveComma(impliedCapsDefs, os, [&](const Record *capDef) {
       os << "Capability::" << EnumAttrCase(capDef).getSymbol();
Index: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
===================================================================
--- mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
+++ mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
@@ -318,4 +318,4 @@
   }
 
   return true;
-};
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72924.238790.patch
Type: text/x-patch
Size: 888 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/0f061493/attachment.bin>


More information about the llvm-commits mailing list