[PATCH] D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 08:40:12 PST 2020


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.cpp:18-20
 // Ideally we would like the only limitation on executing uops to be the issue
 // ports. Maximizing port pressure increases the likelihood that the load is
 // distributed evenly across possible ports.
----------------
mstojanovic wrote:
> I'm not sure how this can be reworded to reflect that it deals with parallel instructions in general rather than just the uops case.
Maybe :
"Ideally we would like the only limitation on executing instructions to be the availability of the CPU resources (e.g. execution ports) needed to execute them, instead of the availability of their data dependencies."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72928/new/

https://reviews.llvm.org/D72928





More information about the llvm-commits mailing list