[PATCH] D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners
Miloš Stojanović via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 17 08:15:35 PST 2020
mstojanovic created this revision.
mstojanovic added reviewers: courbet, gchatelet, petarj.
Herald added subscribers: jsji, atanasyan, tschuett, mgorny, nemanjai, sdardis.
Herald added a project: LLVM.
The addition of `inverse_throughput` mode highlighted the disjointedness of snippet generators and benchmark runners because it used the `UopsSnippetGenerator` with the `LatencyBenchmarkRunner`. To keep the code consistent tie the snippet generators to parallelization/serialization rather than their benchmark runners.
Renaming `LatencySnippetGenerator` -> `SerialSnippetGenerator`.
Renaming `UopsSnippetGenerator` -> `ParallelSnippetGenerator`.
https://reviews.llvm.org/D72928
Files:
llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp
llvm/tools/llvm-exegesis/lib/CMakeLists.txt
llvm/tools/llvm-exegesis/lib/Latency.cpp
llvm/tools/llvm-exegesis/lib/Latency.h
llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp
llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.h
llvm/tools/llvm-exegesis/lib/Mips/Target.cpp
llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.cpp
llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.h
llvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp
llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp
llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.h
llvm/tools/llvm-exegesis/lib/Target.cpp
llvm/tools/llvm-exegesis/lib/Target.h
llvm/tools/llvm-exegesis/lib/Uops.cpp
llvm/tools/llvm-exegesis/lib/Uops.h
llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.cpp
llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.h
llvm/tools/llvm-exegesis/lib/X86/Target.cpp
llvm/unittests/tools/llvm-exegesis/Mips/SnippetGeneratorTest.cpp
llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp
llvm/unittests/tools/llvm-exegesis/X86/SnippetRepetitorTest.cpp
llvm/unittests/tools/llvm-exegesis/X86/TestBase.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72928.238776.patch
Type: text/x-patch
Size: 34454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/84ec9a69/attachment.bin>
More information about the llvm-commits
mailing list