[PATCH] D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D72586#1826339 <https://reviews.llvm.org/D72586#1826339>, @vchuravy wrote:

> In D72586#1825783 <https://reviews.llvm.org/D72586#1825783>, @mehdi_amini wrote:
>
> > Are there other LLVM subproject who inject themselves into the global llvm shared library? Should we have a libMLIR.so instead?
>
>
> Yes I think a libMLIR.so is the right choice, the only reason to go the other way would be if LLVM starts depending on MLIR. A libMLIR.so is a clearer separation and even LTO is split out into its own library.


OK.   It looks like to deal with the whole_archive_link line for mlir-opt, this will have to be aware of which libraries are linked into the shared library, so the cmake machinery mostly needs to be there to handle this anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72586/new/

https://reviews.llvm.org/D72586