[PATCH] D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 06:59:09 PST 2020


peter.smith added a comment.

I'm reluctantly in favour of making the change on the basis that there exists a design using SHF_LINKORDER that lets this happen. My reservation is that in some use cases of SHF_LINKORDER such as .ARM.exidx sections where there is a 1 : 1 relationship between meta-data and "content" (for want of a better word) section then sh_link = 0 would be a sign that something had gone badly wrong. Having said that there isn't any thing in ELF that forbids the use case that this needs. I think that for .ARM.exidx which is the other main user of SHF_LINKORDER we handle it as a special case so this shouldn't make a difference in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72904/new/

https://reviews.llvm.org/D72904





More information about the llvm-commits mailing list