[PATCH] D72921: Create a gpu.module operation for the GPU Dialect.

Theodore Popp via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 06:49:37 PST 2020


tpopp created this revision.
tpopp added a reviewer: herhut.
Herald added subscribers: llvm-commits, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, shauheen, burmako, jpienaar, mehdi_amini, mgorny, jholewinski.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

This is based on the use of code constantly checking for an attribute on
a model and instead represents the distinct operaion with a different
op. Instead, this op can be used to provide better filtering.

Reverts "Revert "[mlir] Create a gpu.module operation for the GPU Dialect.""

This reverts commit ac446302ca4145cdc89f377c0c364c29ee303be5 <https://reviews.llvm.org/rGac446302ca4145cdc89f377c0c364c29ee303be5> after
fixing internal Google issues.

This additionally updates ROCDL lowering to use the new gpu.module.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72921

Files:
  mlir/include/mlir/Conversion/GPUToCUDA/GPUToCUDAPass.h
  mlir/include/mlir/Conversion/GPUToNVVM/GPUToNVVMPass.h
  mlir/include/mlir/Conversion/GPUToROCDL/GPUToROCDLPass.h
  mlir/include/mlir/Dialect/GPU/GPUOps.td
  mlir/lib/Conversion/GPUToCUDA/ConvertKernelFuncToCubin.cpp
  mlir/lib/Conversion/GPUToCUDA/ConvertLaunchFuncToCudaCalls.cpp
  mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
  mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
  mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRVPass.cpp
  mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.td
  mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
  mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
  mlir/test/Conversion/GPUToCUDA/lower-launch-func-to-cuda.mlir
  mlir/test/Conversion/GPUToCUDA/lower-nvvm-kernel-to-cubin.mlir
  mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir
  mlir/test/Conversion/GPUToNVVM/memory-attrbution.mlir
  mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir
  mlir/test/Conversion/GPUToSPIRV/builtins.mlir
  mlir/test/Conversion/GPUToSPIRV/load-store.mlir
  mlir/test/Conversion/GPUToSPIRV/loop.mlir
  mlir/test/Conversion/GPUToSPIRV/simple.mlir
  mlir/test/Dialect/GPU/invalid.mlir
  mlir/test/Dialect/GPU/ops.mlir
  mlir/test/Dialect/GPU/outlining.mlir
  mlir/tools/mlir-cuda-runner/mlir-cuda-runner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72921.238765.patch
Type: text/x-patch
Size: 41570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/47aa3063/attachment.bin>


More information about the llvm-commits mailing list