[PATCH] D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 05:32:24 PST 2020


jhenderson added a comment.

In D72843#1826229 <https://reviews.llvm.org/D72843#1826229>, @grimar wrote:

> Hence the identation length is increased by 2 because of 2 round brackets printed additionally.


Right, I figured it was something like that. Is there any chance of pulling the column header names into separate individual string literals, so that you can do things like sizeof(NameValueStr) or whatever. I'd recommend adding code comments where that is not practical.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72843/new/

https://reviews.llvm.org/D72843





More information about the llvm-commits mailing list