[PATCH] D72914: [FileCheck] Strengthen error checks in unit tests

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre created this revision.
thopre added reviewers: jhenderson, jdenny, probinson, grimar, arichardson, rnk.
thopre added a project: LLVM.
thopre added a parent revision: D72913: [FileCheck] Make Match unittest more flexible.
thopre added a child revision: D60389: FileCheck [9/12]: Add support for matching formats.

This commit adds error checking beyond UndefVarError and fix a number of
Error/Expected related idioms:

- use (EXPECT|ASSERT)_THAT_(ERROR|EXPECTED) instead of errorToBool or boolean operator
- ASSERT when a further check require the check to be successful to give a correct result


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72914

Files:
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72914.238736.patch
Type: text/x-patch
Size: 30973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/a4f38191/attachment.bin>