[PATCH] D72602: [IndVarSimplify][LoopUtils] rewriteLoopExitValues. NFC.

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

These seems like a sensible thing to go along with D72714 <https://reviews.llvm.org/D72714>.



================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:370
+                           ScalarEvolution *SE, SCEVExpander &Rewriter,
+                           DominatorTree *DT, ReplaceExitVal &ReplaceExitValue,
+                           SmallVector<WeakTrackingVH, 16> &DeadInsts);
----------------
ReplaceExitValue needn't be a reference.


================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2781
+      Changed |= rewriteLoopExitValues(L, LI, TLI, SE, Rewriter, DT,
+                                       ReplaceExitValue.getValue(), DeadInsts);
 
----------------
Does this need the getValue()?


================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1138
+
+static bool canLoopBeDeleted(Loop *L, SmallVector<RewritePhi, 8> &RewritePhiSet) {
+  BasicBlock *Preheader = L->getLoopPreheader();
----------------
This was added but not removed anywhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72602/new/

https://reviews.llvm.org/D72602