[PATCH] D72714: [ARM][MVE] Tail-Predication: rematerialise iteration count in exit blocks

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

LGTM, but please address nits before committing.



================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:139
 
+void MVETailPredication::RematerializeIterCount(Loop *L) {
+  SmallVector<WeakTrackingVH, 16> DeadInsts;
----------------
Nit: L is already a member, so it doesn't need to be passed.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:583
   // Now clean up.
-  Cleanup(NewPredicates, Predicates, L);
+  Cleanup(NewPredicates, Predicates, L, ClonedVCTPInExitBlock);
   return true;
----------------
Nit: Just return a bool from Cleanup instead of passing an extra arg.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72714/new/

https://reviews.llvm.org/D72714