[PATCH] D71837: [ARM][MVE] Tail Predicate IsSafeToRemove

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:868
+  if (LoLoop.IsTailPredicationLegal()) {
+    SmallVector<MachineInstr*, 4> Killed;
+    SmallVector<MachineInstr*, 4> Dead;
----------------
SjoerdMeijer wrote:
> I was wondering if it was a bit counter intuitive to start this `ExpandLoopStart` function with removing loop iteration instructions. We have `RemoveDeadBranch` that is called after `ExpandLoopStart`, so perhaps a similar helper function for this?
I think removing the instruction, as well as its operand, in the same place makes sense. It's a bit different to the RemoveDeadBranch because that's really just a hack around the lack of understanding of LEUpdate in the backend.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71837/new/

https://reviews.llvm.org/D71837