[PATCH] D72878: [X86][BranchAlign] Suppress branch alignment for {,_}__tls_get_addr

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 17:47:08 PST 2020


LuoYuanke added inline comments.


================
Comment at: llvm/test/CodeGen/X86/align-branch-boundary-suppressions-tls.ll:21
+; CHECK: #noautopadding
+; 32: leal ld at TLSLDM(%ebx), %eax
+; 32: calll ___tls_get_addr at PLT
----------------
Obviously disable auto padding for TLS is safety, but I am curious what's the problem if we don't  disable it? In our previous patch, we check if there is any variant symbol in needAlignInst(...).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72878/new/

https://reviews.llvm.org/D72878





More information about the llvm-commits mailing list