[PATCH] D72808: [mlir] [VectorOps] Lowering of vector.extract_slices to LLVM IR

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 16:50:24 PST 2020


aartbik added inline comments.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:943
+//
+// TODO(ajcbik): avoid all this by simply relying on DCE
+//
----------------
rriddle wrote:
> Note, we don't run DCE during dialect conversion.
I was under the impression we may introduce that in the future. Rephrased this a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72808/new/

https://reviews.llvm.org/D72808





More information about the llvm-commits mailing list