[PATCH] D72574: [PowerPC][Future] Add pld and pstd to future CPU

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp:281
+  uint64_t Disp = Imm & 0x3FFFFFFFFUL;
+
+  Inst.addOperand(MCOperand::createImm(SignExtend64<34>(Disp)));
----------------
Do we need an `assert` here, as well?


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:472
+  O << '(';
+  printImmZeroOperand(MI, OpNo + 1, O);
+  O << ')';
----------------
nit: spacing between `OpNo + 1`, and to make it consistent with `printMemRegImm34` and the rest of the functions in this file.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp:168
+  // displacement and the next 5 bits as an immediate 0.
+  assert(MI.getOperand(OpNo + 1).isImm() && "Expecting an immedaite.");
+  uint64_t RegBits =
----------------
s/immedaite/immediate.


================
Comment at: llvm/test/MC/Disassembler/PowerPC/future-invalid.txt:1
+# RUN: llvm-mc --disassemble %s -mcpu=future -triple powerpc64-unknown-linux-gnu < %s 2>&1 | FileCheck %s
+
----------------
Line too long?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72574/new/

https://reviews.llvm.org/D72574