[PATCH] D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 15:43:46 PST 2020


dblaikie added a comment.

In D72590#1825399 <https://reviews.llvm.org/D72590#1825399>, @dblaikie wrote:

> I've committed a generalization of this (applying the same logic to all instances of NumLowBitsAvailable) in 65eb74e94b414fcde6bfa810d1c30c7fcb136b77 <https://reviews.llvm.org/rG65eb74e94b414fcde6bfa810d1c30c7fcb136b77> - so this review can be closed or abandoned.


Ah, if I'm reading the other review correctly, this change was/is no longer needed - ah well, it's committed now & not harmful (a little questionable given the lack of storage... but I think it might as well stay that way in hopes of the C++17 future state of things).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72590/new/

https://reviews.llvm.org/D72590





More information about the llvm-commits mailing list