[llvm] de022a8 - [NFC] Fold isHugeExpression into hasHugeExpression and update callers
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 16 15:29:05 PST 2020
Author: Eric Christopher
Date: 2020-01-16T15:28:54-08:00
New Revision: de022a8824f5b528fd428e1397e20c905130eeb1
URL: https://github.com/llvm/llvm-project/commit/de022a8824f5b528fd428e1397e20c905130eeb1
DIFF: https://github.com/llvm/llvm-project/commit/de022a8824f5b528fd428e1397e20c905130eeb1.diff
LOG: [NFC] Fold isHugeExpression into hasHugeExpression and update callers
accordingly.
Added:
Modified:
llvm/lib/Analysis/ScalarEvolution.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 26a9a5ddf1ea..89dcc4793d72 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -872,15 +872,12 @@ static inline int sizeOfSCEV(const SCEV *S) {
return F.Size;
}
-/// Returns true if the subtree of \p S contains at least HugeExprThreshold
-/// nodes.
-static bool isHugeExpression(const SCEV *S) {
- return S->getExpressionSize() >= HugeExprThreshold;
-}
-
-/// Returns true of \p Ops contains a huge SCEV (see definition above).
+/// Returns true if \p Ops contains a huge SCEV (the subtree of S contains at
+/// least HugeExprThreshold nodes).
static bool hasHugeExpression(ArrayRef<const SCEV *> Ops) {
- return any_of(Ops, isHugeExpression);
+ return any_of(Ops, [](const SCEV *S) {
+ return S->getExpressionSize() >= HugeExprThreshold;
+ });
}
namespace {
@@ -3104,8 +3101,7 @@ const SCEV *ScalarEvolution::getMulExpr(SmallVectorImpl<const SCEV *> &Ops,
// Limit max number of arguments to avoid creation of unreasonably big
// SCEVAddRecs with very complex operands.
if (AddRec->getNumOperands() + OtherAddRec->getNumOperands() - 1 >
- MaxAddRecSize || isHugeExpression(AddRec) ||
- isHugeExpression(OtherAddRec))
+ MaxAddRecSize || hasHugeExpression({AddRec, OtherAddRec}))
continue;
bool Overflow = false;
More information about the llvm-commits
mailing list