[PATCH] D72529: [SCCIterator] Fix use-after-free

[Warren Ristow via Phabricator via llvm-commits]

wristow added a comment.

> Jinx ;) This took quite some tracking down on our side - too bad we didn't wait a couple of weeks.

Ah, the luck of timing...

> I do still like the iterator interface better, since it checks against exactly this kind of issue in debug mode. It also avoids the second lookup for the erase. I'll rebase this on top of master.

As I said earlier,  I'm not opposed to replacing my solution with the iterator interface approach.  I won't be offended if you do that! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72529/new/

https://reviews.llvm.org/D72529