[llvm] fa4112f - [llvm-nm] Use `StringRef` over `const std::string &` params

[Sam Clegg via llvm-commits]

Author: Sam Clegg
Date: 2020-01-16T14:02:58-08:00
New Revision: fa4112fffc6bd81ba44a9e6ffb19f4314f6e37b0

URL: https://github.com/llvm/llvm-project/commit/fa4112fffc6bd81ba44a9e6ffb19f4314f6e37b0
DIFF: https://github.com/llvm/llvm-project/commit/fa4112fffc6bd81ba44a9e6ffb19f4314f6e37b0.diff

LOG: [llvm-nm] Use `StringRef` over `const std::string &` params

Differential Revision: https://reviews.llvm.org/D72718

Added: 
    

Modified: 
    llvm/tools/llvm-nm/llvm-nm.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-nm/llvm-nm.cpp b/llvm/tools/llvm-nm/llvm-nm.cpp
index 107d62b1f2b9..28f30a7b37b5 100644
--- a/llvm/tools/llvm-nm/llvm-nm.cpp
+++ b/llvm/tools/llvm-nm/llvm-nm.cpp
@@ -708,8 +708,8 @@ static bool symbolIsDefined(const NMSymbol &Sym) {
 }
 
 static void sortAndPrintSymbolList(SymbolicFile &Obj, bool printName,
-                                   const std::string &ArchiveName,
-                                   const std::string &ArchitectureName) {
+                                   StringRef ArchiveName,
+                                   StringRef ArchitectureName) {
   if (!NoSort) {
     using Comparator = bool (*)(const NMSymbol &, const NMSymbol &);
     Comparator Cmp;
@@ -1184,10 +1184,9 @@ static unsigned getNsectInMachO(MachOObjectFile &Obj, BasicSymbolRef Sym) {
   return (STE.n_type & MachO::N_TYPE) == MachO::N_SECT ? STE.n_sect : 0;
 }
 
-static void
-dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
-                          const std::string &ArchiveName = std::string(),
-                          const std::string &ArchitectureName = std::string()) {
+static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
+                                      StringRef ArchiveName = {},
+                                      StringRef ArchitectureName = {}) {
   auto Symbols = Obj.symbols();
   if (DynamicSyms) {
     const auto *E = dyn_cast<ELFObjectFileBase>(&Obj);