[PATCH] D72861: [InstCombine] Support disabling expensive combines in opt

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 12:47:32 PST 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM

For the new PM question, I assume that's an oversight. I haven't looked too much into the new PM, but I have noticed other possible mistakes there. Eg, it seems like that's running the SpeculativeExecutionPass on all targets?
https://github.com/llvm/llvm-project/blob/53b68e676faf208b4a8f817e9bd4ddd522cc6006/llvm/lib/Passes/PassBuilder.cpp#L427

vs:

https://github.com/llvm/llvm-project/blob/53b68e676faf208b4a8f817e9bd4ddd522cc6006/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp#L342


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72861/new/

https://reviews.llvm.org/D72861





More information about the llvm-commits mailing list