[PATCH] D72844: AMDGPU: Move permlane discard vdst_in optimization

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 12:37:26 PST 2020


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/VOP3Instructions.td:682
+
+  def : PermlaneDiscardVDstIn<
+    BoundControlOrFetchInvalidPermlane<int_amdgcn_permlane16>,
----------------
arsenm wrote:
> rampitec wrote:
> > Don't you need added complexity here? The complexity of both patterns looks the same.
> No, I think the custom predicate boosts the complexity score
Right, found it here: https://github.com/llvm-mirror/llvm/blob/master/utils/TableGen/CodeGenDAGPatterns.cpp#L1357


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72844/new/

https://reviews.llvm.org/D72844





More information about the llvm-commits mailing list