[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 09:54:04 PST 2020


SouraVX marked 3 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1187
+      // attribute.
+      if (CUNode->getMacros()) {
+        if (getDwarfVersion() >= 5) {
----------------
aprantl wrote:
> this check is oddly redundant?
Oh Sorry, that must've crept up/left while segregating the dwarf-dump and this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828





More information about the llvm-commits mailing list