[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetLoweringObjectFile.h:221
+
+  /// On targets that support TOC entries, return a section for the entry given
+  /// the symbol it refers to.
----------------
daltenty wrote:
> hubert.reinterpretcast wrote:
> > https://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi-1.9.html mentions TOC entries. Did we implement this function for the corresponding LLVM implementation?
> I can add the ELF change if we think it is in scope, though this will make this no longer an XCOFF only patch. Perhaps we better do that as a follow on patch?
The second this lands, having the interface here without a TODO comment suggests that it is already implemented for the existing targets for which it applies. The alternative consideration is whether the scope of the interface is correct. Should it be clearly more XCOFF specific and should it be a virtual function at this level of the class hierarchy at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347