[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/response.test:27
+
+# RUN: echo "rc %t.a blah\foo" > %t-rsp.txt
+# RUN: not llvm-ar --rsp-quoting=windows @%t-rsp.txt 2>&1 | \
----------------
MaskRay wrote:
> MaskRay wrote:
> > Prefer single quotes. It does less translation. Shell quoting is difficult. With single quotes, a reader can think less what happens here.
> If you do want a form feed, you need `echo -e`.
> 
> You are currently using a bash/zsh extension.
I wasn't looking for a form feed but have used `echo -e` to clarify what is output


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665