[PATCH] D72792: [SVE] Pass Scalable argument to VectorType::get in Bitcode Reader

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Thanks for these fixes. LGTM!



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:4172
+
+      ElementCount EC1 = cast<VectorType>(Vec1->getType())->getElementCount();
+
----------------
nit: You can write `Vec->getType()->getVectorElementCount()` without having to do the cast first.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:4174
+
+      if (EC1 != cast<VectorType>(Vec2->getType())->getElementCount())
+        return error("Mismatch between argument types");
----------------
nit: same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72792/new/

https://reviews.llvm.org/D72792