[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetLoweringObjectFile.h:221
+
+  /// On targets that support TOC entries, return a section for the entry given
+  /// the symbol it refers to.
----------------
hubert.reinterpretcast wrote:
> https://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi-1.9.html mentions TOC entries. Did we implement this function for the corresponding LLVM implementation?
I can add the ELF change if we think it is in scope, though this will make this no longer an XCOFF only patch. Perhaps we better do that as a follow on patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347