[PATCH] D72854: [mlir] Generalize m_ConstantIndexOp

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/include/mlir/IR/Matchers.h:88
+  /// attribute value if match succeeds.
+  constant_index_op_binder(IntegerAttr *bv) : bind_value(bv) {}
+  /// Create a matcher instance that doesn't bind if match succeeds.
----------------
Please add `explicit` to avoid spurious implicit conversions 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72854/new/

https://reviews.llvm.org/D72854