[PATCH] D72833: [GlobalISel] Use more MachineIRBuilder helper methods

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 07:59:51 PST 2020


foad marked 2 inline comments as done.
foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1444
+    auto AndOp = MIRBuilder.buildAnd(
+        WideTy, NewOp, MIRBuilder.buildConstant(WideTy, Mask.getZExtValue()));
     // There is no overflow if the AndOp is the same as NewOp.
----------------
arsenm wrote:
> This should be fixed separately l, but the getZExtValue is unnecessary and will break for wider types
See D72853.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72833/new/

https://reviews.llvm.org/D72833





More information about the llvm-commits mailing list