[PATCH] D72834: [mlir] LLVM import: handle constant data and array/vector aggregates

[Alex Zinenko via Phabricator via llvm-commits]

ftynse marked an inline comment as done.
ftynse added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp:254
+  }
+
+  llvm_unreachable("no equivalent standard type for typed attributes");
----------------
nicolasvasilache wrote:
> How about LLVM struct?
We don't have a well-defined way of representing constants of struct type in the dialect. Since this code asserts (or even crashes) on unsupported inputs, I added an assert as well. The follow up (D72839) will replace all asserts including this one by graceful error handling.

I could just report an error and return nullptr here, but it would crash two steps up in the call stack...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72834/new/

https://reviews.llvm.org/D72834