[PATCH] D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 16 06:25:34 PST 2020
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:434
+
+## When printing a values row we want to have a minimal reasonable indentation.
+## Use an arbitrary dynamic tag to demonstrate that.
----------------
"a values row" -> "the value column"
"a minimal reasonable indentation" -> "the minimal possible indentation"
================
Comment at: llvm/tools/llvm-objdump/ELFDump.cpp:166
+
+ // Find the maximum tag name length to format the value row properly.
+ size_t MaxLen = 0;
----------------
value row -> value column
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72838/new/
https://reviews.llvm.org/D72838
More information about the llvm-commits
mailing list