[PATCH] D72763: [mlir][spirv] Use sybmolize functions in enum attribute predicates

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked an inline comment as done.
antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td:2967
     ]> {
+  let predicate = And<[
+    IntegerAttrBase<I32, "">.predicate,
----------------
benvanik wrote:
> optional: it would make this file more readable if this was instead a class; `let predicate = I32EnumAttrIsSymbolizable<"SelectionControl"> etc`
Good point! This stuff can indeed be deduplicated. I created new wrapper classes to set this there to avoid have each enum to have it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72763/new/

https://reviews.llvm.org/D72763