[PATCH] D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 16 06:10:30 PST 2020
nicolasvasilache added a comment.
>From a cursory glance this looks good, I'd use the capital name for enums that conflict with C/C++ keywords.
I'm also very +1 on mirroring LLVM and staying in sync with https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/AtomicOrdering.h#L81.
It makes sense that MLIR would be exactly as "wrong" as LLVM in unsurprising ways.
I feel that developers of frontend X should not have to go read the C++ standard or papers about C++ and Java to understand why there is a surprising mismatch between LLVM and MLIR.
But it seems this would be a good topic to bring to the LLVM community as a whole and then MLIR can just follow?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72741/new/
https://reviews.llvm.org/D72741
More information about the llvm-commits
mailing list