[PATCH] D72451: [ARM][MVE] Enable extending gathers

[Anna Welker via Phabricator via llvm-commits]

anwel marked 3 inline comments as done.
anwel added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:249
+  unsigned Unsigned = 1;
+  // If this is an extending gather, a SExt or ZExt must be following
+  auto *Extend = Root;
----------------
dmgreen wrote:
> Can you add a comment saying something like "we have already checked the size of the gather in isLegalTypeAndAlignment, and need to check that the extend is to a full vector width."
Yes, I'll rephrase that comment to be more informative


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72451/new/

https://reviews.llvm.org/D72451