[PATCH] D72833: [GlobalISel] Use more MachineIRBuilder helper methods
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 16 05:24:39 PST 2020
arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1444
+ auto AndOp = MIRBuilder.buildAnd(
+ WideTy, NewOp, MIRBuilder.buildConstant(WideTy, Mask.getZExtValue()));
// There is no overflow if the AndOp is the same as NewOp.
----------------
This should be fixed separately l, but the getZExtValue is unnecessary and will break for wider types
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72833/new/
https://reviews.llvm.org/D72833
More information about the llvm-commits
mailing list