[PATCH] D72732: [GVN] introduce GVNOptions to control GVN pass behavior

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 02:26:45 PST 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:636
+  bool Changed = runImpl(F, AC, DT, TLI, AA,
+                         isMemDepEnabled() ? &MemDep : nullptr, LI, &ORE);
   if (!Changed)
----------------
fedor.sergeev wrote:
> fedor.sergeev wrote:
> > asbirlea wrote:
> > > Conditionally getResult<MemDepAnalysis> in a follow up change?
> > Yep, will do as a separate one-liner after this patch.
> since this patch became rather involved on legacy part anyway, 
> I decided that doing this change here (and not in a followup) is fine.
Sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72732/new/

https://reviews.llvm.org/D72732





More information about the llvm-commits mailing list