[PATCH] D72820: Add pragma FP_CONTRACT support.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 19:48:11 PST 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7064
+
+  auto pushOutChain = [&]() {
+    assert(Result.getNode()->getNumValues() == 2);
----------------
Can you make the SDValue Result an argument of this and only capture 'this'. I don't like depending on reassigning Result.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72820/new/

https://reviews.llvm.org/D72820





More information about the llvm-commits mailing list