[PATCH] D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX

Steven Wan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 18:52:27 PST 2020


stevewan marked 2 inline comments as done.
stevewan added inline comments.


================
Comment at: llvm/tools/llc/llc.cpp:469
+    WithColor::error(errs(), argv[0])
+        << "invalid relocation model, AIX only supports PIC.\n";
+    return 1;
----------------
hubert.reinterpretcast wrote:
> A "lit" test that checks for this error message for would be appropriate. I would suggest checking that setting PIC explicitly works for both 32-bit and 64-bit AIX and setting other-than-PIC generates an error message for the same.
Thanks for pointing out, LIT case added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72479/new/

https://reviews.llvm.org/D72479





More information about the llvm-commits mailing list