[PATCH] D72068: [IR] Refactor SubclassData
Ehud Katz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 15 13:29:08 PST 2020
ekatz added a comment.
In D72068#1822503 <https://reviews.llvm.org/D72068#1822503>, @rnk wrote:
> I feel like this is creating too much unnecessary abstraction. I think we can use simple techniques, like unions, as I did here in this uncommitted patch:
> https://reviews.llvm.org/D51664#C1373737NL442
> Even better, we can do that incrementally, without many changes to the get/set value subclass data APIs.
I do not think it is unnecessary, as we gain so much from it, right away, and also a lot of potential for future improvements.
I think it's worth the benefits listed in the summary.
This may be a large change, but if you look closely, it is not that big of a deal - it is pretty intuitive.
The change is large only due to the large number of subclass data flags.
I can always separate it to 2 changes (or more if possible).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72068/new/
https://reviews.llvm.org/D72068
More information about the llvm-commits
mailing list