[PATCH] D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Looks fine to me as a first step, with more uncommented code and a not very actionable FIXME removed :)

Maybe wait until EOD to see if rnk wants to chime in too.



================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:288
+  std::string FeaturesStr;
+  //if (MAttrs.size()) {
+    //SubtargetFeatures Features;
----------------
?


================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:358
+        /*DWARFMustBeAtTheEnd*/ false));
+    //if (NoExecStack)
+      //Str->InitSections(true);
----------------
?


================
Comment at: llvm/utils/gn/secondary/llvm/tools/llvm-ml/BUILD.gn:13
+  sources = [
+    # FIXME: duplicating this is stupid
+    "Disassembler.cpp",
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72679/new/

https://reviews.llvm.org/D72679