[PATCH] D72803: Make lld cmake not compute commit revision twice
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 15 13:00:39 PST 2020
thakis created this revision.
thakis added a reviewer: ruiu.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.
r354605 moved LLD to the unified revision handling introduced in
rL353268 <https://reviews.llvm.org/rL353268> / r352729 and removed uses of LLD_REPOSITORY_STRING and
LLD_REVISION_STRING.
After this change, we no longer compute the (now-unused) values
of these two variables.
Since this removes the only use of llvm/utils/GetRepositoryPath,
remove that too (it's redundant with the system added in r354605).
While here, also remove LLD_VERSION_MAJOR and LLD_VERSION_MINOR.
Their uses were removed in r285163.
Also remove LLD_VERSION from Version.inc which as far as I can
tell has been unused since the file was added in r219277.
No behavior change.
https://reviews.llvm.org/D72803
Files:
lld/CMakeLists.txt
lld/include/lld/Common/Version.inc.in
llvm/utils/GetRepositoryPath
llvm/utils/gn/secondary/lld/include/lld/Common/BUILD.gn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72803.238341.patch
Type: text/x-patch
Size: 3818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200115/d142f5f5/attachment.bin>
More information about the llvm-commits
mailing list