[PATCH] D70557: [lld][COFF] Add support for /map

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

A couple of nits, but I think it looks pretty good, thanks!



================
Comment at: lld/COFF/MapFile.cpp:71
+  });
+  v.resize(std::distance(v.begin(), end));
+
----------------
Is `v.erase(end, v.end())` not more idiomatic?


================
Comment at: lld/test/COFF/map.test:27
+# MAP-NEXT: 0002:00000040       __imp_exportfn1            0000000140002040     map.test.tmp-dll:map.test.tmp.dll
+# MAP-NEXT: 0002:00000048       __imp_exportfn2            0000000140002048     map.test.tmp-dll:map.test.tmp.dll
+# MAP-EMPTY:
----------------
Please add some absolute symbols with "negative" RVAs to the inputs, since those are an interesting edge case in the sorting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70557/new/

https://reviews.llvm.org/D70557