[PATCH] D70247: [JumpThreading] Thread jumps through two basic blocks

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/test/Transforms/JumpThreading/thread-two-bbs3.ll:8
+; CHECK-LABEL: @foo
+; CHECK-LABEL: entry
+; Verify that we do *not* thread any edge.  On Windows, we used to
----------------
We usually use CHECK instead of CHECK-LABEL for BasicBlock label.


================
Comment at: llvm/test/Transforms/JumpThreading/thread-two-bbs3.ll:12
+; assertion failure later down the pass pipeline.
+; CHECK-NOT: thread
+entry:
----------------
Can we make the check more robust? It is possible the same word "thread" appears in somewhere else or in the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70247/new/

https://reviews.llvm.org/D70247