[llvm] aed52fd - [gn build] make "gn format" comment slightly more concise
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 15 10:39:51 PST 2020
Author: Nico Weber
Date: 2020-01-15T13:36:42-05:00
New Revision: aed52fd483744b74e979e18028a6f9bcb2c30a36
URL: https://github.com/llvm/llvm-project/commit/aed52fd483744b74e979e18028a6f9bcb2c30a36
DIFF: https://github.com/llvm/llvm-project/commit/aed52fd483744b74e979e18028a6f9bcb2c30a36.diff
LOG: [gn build] make "gn format" comment slightly more concise
Added:
Modified:
llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
llvm/utils/gn/secondary/libcxx/src/BUILD.gn
llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn
llvm/utils/gn/secondary/libunwind/src/BUILD.gn
Removed:
################################################################################
diff --git a/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn b/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
index f0602a7d97c3..2c33adb2a6d4 100644
--- a/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
+++ b/llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
@@ -174,8 +174,7 @@ static_library("builtins") {
if (current_os != "fuchsia" && !compiler_rt_baremetal_build) {
sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"clear_cache.c",
]
}
@@ -425,14 +424,13 @@ static_library("builtins") {
if (current_cpu == "arm64") {
sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"aarch64/fp_mode.c",
]
if (current_os == "mingw") {
sources += [
- # This comment prevents `gn format` from putting the file on the same
- # line as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for
+ # sync_source_lists_from_cmake.py.
"aarch64/chkstk.S",
]
}
diff --git a/llvm/utils/gn/secondary/libcxx/src/BUILD.gn b/llvm/utils/gn/secondary/libcxx/src/BUILD.gn
index f96e4e07246a..ea15963bf560 100644
--- a/llvm/utils/gn/secondary/libcxx/src/BUILD.gn
+++ b/llvm/utils/gn/secondary/libcxx/src/BUILD.gn
@@ -172,8 +172,7 @@ if (target_os == "win") {
}
if (target_os == "solaris") {
cxx_sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"support/solaris/xlocale.cpp",
]
}
@@ -185,8 +184,7 @@ if (libcxx_enable_filesystem) {
]
if (libcxx_use_compiler_rt) {
cxx_sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"filesystem/int128_builtins.cpp",
]
}
diff --git a/llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn b/llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn
index d84d57d0d71a..44712caf4d01 100644
--- a/llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn
+++ b/llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn
@@ -18,8 +18,7 @@ declare_args() {
}
cxxabi_headers = [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"../include/cxxabi.h",
]
@@ -55,15 +54,13 @@ if (libcxxabi_enable_exceptions) {
]
} else {
cxxabi_sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"cxa_noexception.cpp",
]
}
if (target_os == "linux" || target_os == "fuchsia") {
cxxabi_sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"cxa_thread_atexit.cpp",
]
}
diff --git a/llvm/utils/gn/secondary/libunwind/src/BUILD.gn b/llvm/utils/gn/secondary/libunwind/src/BUILD.gn
index 9b118045b246..af1936878654 100644
--- a/llvm/utils/gn/secondary/libunwind/src/BUILD.gn
+++ b/llvm/utils/gn/secondary/libunwind/src/BUILD.gn
@@ -17,8 +17,7 @@ unwind_headers = [
]
if (target_os == "mac") {
unwind_headers += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"../include/mach-o/compact_unwind_encoding.h",
]
}
@@ -46,8 +45,7 @@ unwind_sources = [
]
if (target_os == "mac") {
unwind_sources += [
- # This comment prevents `gn format` from putting the file on the same line
- # as `sources +=`, for sync_source_lists_from_cmake.py.
+ # Make `gn format` not collapse this, for sync_source_lists_from_cmake.py.
"Unwind_AppleExtras.cpp",
]
}
More information about the llvm-commits
mailing list