[PATCH] D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc

[Eric Astor via Phabricator via llvm-commits]

epastor added inline comments.


================
Comment at: llvm/tools/llvm-ml/Disassembler.h:10
+// This class implements the disassembler of strings of bytes written in
+// hexadecimal, from standard input or from a file.
+//
----------------
thakis wrote:
> Is this comment up-to-date? Should probably mention ml?
This is accurate; Disassembler.h and Disassembler.cpp are identical to that in llvm-mc. The only difference is that when run as part of llvm-ml, it will be passed different parameters by default. Is there a way I can share the code between them instead?


================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:124
+static cl::list<std::string>
+DebugPrefixMap("fdebug-prefix-map",
+               cl::desc("Map file source paths in debug info"),
----------------
thakis wrote:
> Even more important than this flag is -fdebug-compilation-dir (ctrl-f "fdebug-compilation" in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html )
Already in place; see above.


================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:210
+
+  // XXX hm
+  std::unique_ptr<MCTargetAsmParser> TAP(
----------------
thakis wrote:
> Hm!
> 
> Elaborate, or remove
Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72679/new/

https://reviews.llvm.org/D72679